Skip to content

Update cattrs tests#633

Merged
AlexWaygood merged 7 commits into
python:mainfrom
Tinche:tin/cattrs-uv
Jul 23, 2025
Merged

Update cattrs tests#633
AlexWaygood merged 7 commits into
python:mainfrom
Tinche:tin/cattrs-uv

Conversation

@Tinche

@Tinche Tinche commented Jul 19, 2025

Copy link
Copy Markdown
Contributor

Updates the CI configuration for cattrs to use uv.

@Tinche

Tinche commented Jul 19, 2025

Copy link
Copy Markdown
Contributor Author

I see actions/setup-python@v5 is being used here. In my own CI I've just switched to letting uv handle the Python installation for me.

@JelleZijlstra

Copy link
Copy Markdown
Member

Thanks! I'd be open to switching to setup-uv here.

@AlexWaygood

Copy link
Copy Markdown
Member

Yeah, I think when we first started using uv in parts of this workflow, uv wasn't yet able to install Python for you and setup-uv didn't yet exist (just the curl command). I'm also open to modernising it a bit!

@Tinche

Tinche commented Jul 20, 2025

Copy link
Copy Markdown
Contributor Author

I switched everything to astral-sh/setup-uv, let me know how it looks!

@AlexWaygood

Copy link
Copy Markdown
Member

For the ones where we're manually uv pip installing dependencies, I think you'll need to create a virtual environment to pip install them into (the --system flag for uv pip install won't work if we're using a uv-managed Python installation).

You'll also need to pin the action to an exact hash to make zizmor happy in pre-commit, I think!

Comment thread .github/workflows/third_party.yml Outdated

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlexWaygood AlexWaygood merged commit 9471a44 into python:main Jul 23, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants